#114 (relic code?) sisboyparty has no assignment to 2

Closed
opened 4 years ago by Prinplup · 2 comments
Prinplup commented 4 years ago

sisboyparty

!-1 - don''t go to the party
!0 - don''t know about parties
!1 - knows about the parties
!2 - agreed to go to the party
!3 - Missed the party

sisterQW['party']

!-1 - don''t go to the party
!0 - don''t know about it
!1 - agreed to go to the party
!2 - been to the party

Searching through the qsp i dont think there is anywhere sisboyparty can be set to 2.

The code in sister (search for "You agree to go to the party") sets sisterQW['party'] = 1 but not sisboyparty = 2, which appears to have been set in my 7.3 qsp file.

It appears that the code was halfway through refactoring (using sisterQW['party'] in place of sisboyparty as the state variable), so there might be bugs somewhere. I admittedly havn't playtested it yet though.

sisboyparty !-1 - don''t go to the party !0 - don''t know about parties !1 - knows about the parties !2 - agreed to go to the party !3 - Missed the party sisterQW['party'] !-1 - don''t go to the party !0 - don''t know about it !1 - agreed to go to the party !2 - been to the party Searching through the qsp i dont think there is anywhere sisboyparty can be set to 2. The code in sister (search for "You agree to go to the party") sets sisterQW['party'] = 1 but not sisboyparty = 2, which appears to have been set in my 7.3 qsp file. It appears that the code was halfway through refactoring (using sisterQW['party'] in place of sisboyparty as the state variable), so there might be bugs somewhere. I admittedly havn't playtested it yet though.
KeyMasterOfGozer commented 4 years ago
Collaborator

Look like there used to be a file "annafrends.qsrc" that set thee values. It was removed by Sicaa on December 21, 2019 at 6:54:22 AM EST commit : b3f6d2e1a0 comment: [fixed] bug hunting in and around the new sister stuff & some code cleanup, variable unification and location merging in the party files

Look like there used to be a file "annafrends.qsrc" that set thee values. It was removed by Sicaa on December 21, 2019 at 6:54:22 AM EST commit : b3f6d2e1a0dc6f69f605876b92ab1933ba4028b8 comment: [fixed] bug hunting in and around the new sister stuff & some code cleanup, variable unification and location merging in the party files
Kevin_Smarts commented 4 years ago
Owner

This has been patched for now and will be redone as we roll out the new party in the next dev cycle. Thanks!

This has been patched for now and will be redone as we roll out the new party in the next dev cycle. Thanks!
Sign in to join this conversation.
No Label
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.