#169 Make the Unix build script executable

Merged
Kevin_Smarts merged 1 commits from ezsh/feature/executable-build-script into Kevin_Smarts/master 2 år sedan
ezsh kommenterad 3 år sedan
Det finns inget innehåll än.
ezsh kommenterad 3 år sedan
Skapare

ping?

ping?
Kevin_Smarts kommenterad 2 år sedan
Ägare

None of us use unix to know if this works, but more importantly removing the python command would appear to break Windows use.

None of us use unix to know if this works, but more importantly removing the python command would appear to break Windows use.
ezsh kommenterad 2 år sedan
Skapare

If you mean build.sh, isn't it Unix-only file?

If you mean `build.sh`, isn't it Unix-only file?
yanchi kommenterad 2 år sedan

Since I'm using macOS (a unix os) and Windows, my answer is YES.

But Windows can run build.sh in msys, cygwin (Just like in this script. You can find more here!)

If you remove python command, you need to add a shebang in the corresponding python file, which will lead to a unknown python version.

What's more, the current build script is already executable. (I pulled a pr about the build script before to make it work and it worked well on my both computers.) If you still don't understand, please leave a message below to let me know if I can help.

Since I'm using macOS (a unix os) and Windows, my answer is YES. But Windows can run `build.sh` in `msys`, `cygwin` (Just like in this script. You can find more [here](https://en.wikipedia.org/wiki/Shell_script)!) If you remove `python` command, you need to add a `shebang` in the corresponding python file, which will lead to a unknown python version. What's more, the current build script is already executable. (I pulled a pr about the build script before to make it work and it worked well on my both computers.) If you still don't understand, please leave a message below to let me know if I can help.
ezsh kommenterad 2 år sedan
Skapare

If you remove python command, you need to add a shebang in the corresponding python file

It's already there.

What's more, the current build script is already executable.

I just update the master branch and it is not executable:

$ stat -c "%a" build.sh                                                                                                       
644
> If you remove python command, you need to add a shebang in the corresponding python file It's already there. > What's more, the current build script is already executable. I just update the master branch and it is not executable: ``` $ stat -c "%a" build.sh 644 ```
yanchi kommenterad 2 år sedan

it is not executable

You need to run bash build.sh. If you want to run it in the ./build.sh way, you need to be the root user. And that's why we set the Access Control Lists to 755 for txt2gam* scripts (we can't find a proper interpreter)

> it is not executable You need to run `bash build.sh`. If you want to run it in the `./build.sh` way, you need to be the root user. And that's why we set the Access Control Lists to 755 for `txt2gam*` scripts (we can't find a proper interpreter)
ezsh kommenterad 2 år sedan
Skapare

What root user you are talking about? Why ACLs has anything to do with this? I just want to set the executable bit for scripts that already have proper shebangs.

txt2gam utility is not a script but compiled executable, it can be "interpreted" by a virtual machine only.

What root user you are talking about? Why ACLs has anything to do with this? I just want to set the executable bit for scripts that already have proper shebangs. txt2gam utility is not a script but compiled executable, it can be "interpreted" by a virtual machine only.
yanchi kommenterad 2 år sedan

by a virtual machine only

It seems like you have no ideas about *nix on Windows... So It's hard for me to explain it to you.

> by a virtual machine only It seems like you have no ideas about *nix on Windows... So It's hard for me to explain it to you.
ezsh kommenterad 2 år sedan
Skapare

Yes, I have no idea how does that work on Windows. Update the PR to include only mode changes.

Yes, I have no idea how does that work on Windows. Update the PR to include only mode changes.
ezsh kommenterad 2 år sedan
Skapare

@Kevin_Smarts, this PR now only changes file modes and should not break anything on any platform.

@Kevin_Smarts, this PR now only changes file modes and should not break anything on any platform.
JackTruman kommenterad 2 år sedan

Can confirm this makes sense and works on linux.

Can confirm this makes sense and works on linux.
This pull request has been merged successfully!
Logga in för att delta i denna konversation.
Ingen Etikett
Ingen Milsten
Ingen förvärvare
4 Deltagare
Laddar...
Avbryt
Spara
Det finns inget innehåll än.